muellan / metacache

memory efficient, fast & precise taxnomomic classification system for metagenomic read mapping
GNU General Public License v3.0
57 stars 12 forks source link

Make throws the Invalid Option error if multiple macros are passed #34

Closed banderoz closed 1 year ago

banderoz commented 2 years ago

Hi there!

When I try building the metacache package (v2.2.3) with multiple macros, make throws the invalid option error: image

Seems like $(MACROS) should be quoted here: https://github.com/muellan/metacache/blob/532a737ffca173e264a28b8349a8da98cbf0aeb6/Makefile#L136

For now, I build metacache by running this command directly: make release_dummy DIR=build_release ARTIFACT=metacache MACROS="-DMC_TARGET_ID_TYPE=uint32_t -DMC_WINDOW_ID_TYPE=uint32_t"

BR, Zulfat

Funatiq commented 2 years ago

Thank you for your report. It will be fixed in the next version.