search

mueller-ma / MuteReminder

Android app to remind you to mute media
Apache License 2.0
37 stars 4 forks source link

Unmute option tab in app #113

Closed shreyashdelmade0744 closed 11 months ago

shreyashdelmade0744 commented 11 months ago

Hi @mueller-ma I would like to work on unmute feature in this repo under hactoberfest Can you please assign this issue to me ?

Thank You

mueller-ma commented 11 months ago

Where would you add such a button to unmute? And to what level do you want to set the volume?

shreyashdelmade0744 commented 11 months ago

@mueller-ma To main activity and will set to level 8

mueller-ma commented 11 months ago

Why 8 and not 7 or 9?

shreyashdelmade0744 commented 11 months ago

my device has 16 level therefore taking mid value 😃

shreyashdelmade0744 commented 11 months ago

@mueller-ma Can you guide me what exact level of volume to set or anything else ?

Maan-Sharma commented 11 months ago

Can I work on it

mueller-ma commented 11 months ago

The middle level might be too loud. I don't think it's worth to add such a feature as it's not predictable for the user how loud it gets.

mueller-ma commented 11 months ago

If you want to contribute for hacktoberfest there're other issues in this project and also one PR with a dependency bump that requires manual migration.