search

mueller-ma / PrepaidBalance

App to check your prepaid balance
Apache License 2.0
35 stars 14 forks source link

Another missing parsing of a Vodafone USSD response #255

Closed cyclingcat closed 9 months ago

cyclingcat commented 9 months ago

Describe the bug The German Vodafone reseller "Lidl Connect" recently sent a USSD response that includes the service phone number 22922, which is currently misinterpreted as an account balance "22.922,00". See the screenshot:

Lidl

App version 2.3 from F-Droid. (The marked "9,00" at the top of the screen seems to be fixed with v2.4, which is not on F-Droid yet.)

Device (please complete the following information):

This is similar to issue #249.

The cycling cat

mueller-ma commented 9 months ago

I thought this is easy to fix, but it seems String.startsWith breaks on umlauts...

https://github.com/mueller-ma/PrepaidBalance/pull/256

mueller-ma commented 9 months ago

I replace many special chars by whitespace here: https://github.com/mueller-ma/PrepaidBalance/blob/main/app/src/main/java/com/github/muellerma/prepaidbalance/utils/ResponseParser.kt#L25