muenzpraeger / salesforce-einstein-platform-apex

Apache License 2.0
88 stars 51 forks source link

Internal error occurs when email is not set in custom settings #68

Closed pozil closed 6 years ago

pozil commented 6 years ago

If you do not set your email in the custom settings, an internal error occurs as soon as you navigate to the Playground or Einstein Usage tab.

The error does not tell anything about what's wrong. May I suggest that you reinstate my previous contribution with the configuration checks that were reporting config errors?

screen shot 2018-02-15 at 14 25 08

ankushsomani09 commented 6 years ago

Did you sign up to https://api.einstein.ai and downloaded the key. and upload that file in org. or either store in certificate management,

pozil commented 6 years ago

Thanks but I know what I did wrong. My point is that there should not be a generic internal error, there should be a clear error message.

On Feb 23, 2018 12:25, "Ankush Somani" notifications@github.com wrote:

Did you sign up to https://api.einstein.ai and downloaded the key. and upload that file in org. or either store in certificate management,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/muenzpraeger/salesforce-einstein-platform-apex/issues/68#issuecomment-367983842, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1jl3vdqBNbYDLqr3LYXilWHoN24n5Hks5tXqAggaJpZM4SG19H .

muenzpraeger commented 6 years ago

The previous check by @pozil only checked for file and email, while the current wrapper also includes very based with based on a key. It’s tricky to define the “correct” check (but feel free to contribute, it’s open source ;-)).

Having said that there may be a general change in the future - SAFE HARBOR - for how the auth mechanism is provided.

muenzpraeger commented 6 years ago

“cert based auth”, not “very based”, thank you autocorrect. ;-)