search

mueschel / OsmDestinationSigns

Display of OSM destination signs
9 stars 6 forks source link

Time is only displayed on first destination with space characters in time=* (destination_sign relation) #12

Closed dafadllyn closed 6 months ago

dafadllyn commented 6 months ago

If the value of time=* in a type=destination_sign relations includes space characters, the time is only displayed on the first destination, e.g.:

time="0:05; 0:25; 0:40; 0:20; 0:35"

After having removed the space characters, all durations are displayed:

time="0:05;0:25;0:40;0:20;0:35"

Example is from here (currently w/o space characters): https://osm.mueschelsoft.de/destinationsign/example/index.htm#node=10087766313&namedroutes=1&fromarrow=0&include_sgn=1&include_way=1&country=

Another example with a space characters after semicolons: https://osm.mueschelsoft.de/destinationsign/example/index.htm#node=10087766313&namedroutes=1&fromarrow=0&include_sgn=1&include_way=1&country=

mueschel commented 6 months ago

Thanks for noticing. Indeed one of my parsing strings for the various ways how time is tagged missed the possible spaces.

Here's a relation that still has the spaces: https://osm.janmichel.eu/destinationsign/example/index.htm#node=8989980795&namedroutes=1&fromarrow=0&include_sgn=1&include_way=1&country=

Should be fixed now! https://github.com/mueschel/OsmDestinationSigns/commit/e96e3605dd7b22b98288f5313e11d96bed3f1400