search

muesli / beehive

A flexible event/agent & automation system with lots of bees 🐝
GNU Affero General Public License v3.0
6.31k stars 324 forks source link

filesystem notification bee #150

Closed rubiojr closed 7 years ago

rubiojr commented 7 years ago

A bee that reacts to filesystem events and forwards them to other bees interested.

rubiojr commented 7 years ago

Wondering now if I should switch to https://github.com/rjeczalik/notify that supports recursivity and FSEvents on macOS (more efficient apparently).

rubiojr commented 7 years ago

Wondering now if I should switch to https://github.com/rjeczalik/notify that supports recursivity and FSEvents on macOS (more efficient apparently).

We talked about this on IRC. Recursivity (without proper control) is dangerous and kqueue is probably good enough for macOS and this particular case, so sticking to https://github.com/fsnotify/fsnotify for now.

Unrelated to the previous comment: it seems that the new fsnotify dep pulls x/sys/unix which breaks Go 1.3. @muesli, how do you feel about building with go >= 1.4 and 🔥 1.3?

muesli commented 7 years ago

That's a good question indeed. I guess after the 0.3 release (which should be imminent), I'd like to bump our Golang dependency to 1.7, so we can rely on the context package. Maybe we should keep the 1.3 dep for our 0.3 release and merge the fsnotify-bee afterwards?

rubiojr commented 7 years ago

Maybe we should keep the 1.3 dep for our 0.3 release and merge the fsnotify-bee afterwards?

👍

muesli commented 7 years ago

I guess I need to re-enable 'go get'-ing all the dependencies (as opposed to relying on vendoring only), otherwise tests for such pull requests will fail. Sorry for that, I'll fix that on my side and merge your PR if you're ready.

rubiojr commented 7 years ago

:bow: