muesli / beehive

A flexible event/agent & automation system with lots of bees 🐝
GNU Affero General Public License v3.0
6.3k stars 324 forks source link

Add Rocket.Chat hive #261

Closed dvob closed 5 years ago

dvob commented 5 years ago

Add hive which allows to send messages into a Rocket.Chat channel.

muesli commented 5 years ago

Nice work! A few more comments:

dvob commented 5 years ago

Thank you for revewing the code. I added my self as author and changed the description of the alias setting.

When I find some time, I may implement support for events as well. But right now, for me sending messages has priority.
I agree that if the Rocket.Chat API client grows it should become its own library, but for now I think its ok like that. If I implement the event part I probably use https://github.com/detached/gorocket, but currently two things in gorocket are missing:

The logo looks good on me. Did you look at the logo in Github and didn't see the scrollbar under the picture?

muesli commented 5 years ago

Hah, sorry about that, you're right about the logo! LGTM!