Closed dvob closed 5 years ago
Nice work! A few more comments:
client.go
could almost become its own library. I'm fine with it for now, seeing how the scope is still fairly limited, but it's something one should eventually think about.
it would be nice to have events, too!
the logo seems to be cut off at the right border?
Thank you for revewing the code. I added my self as author and changed the description of the alias setting.
When I find some time, I may implement support for events as well. But right now, for me sending messages has priority.
I agree that if the Rocket.Chat API client grows it should become its own library, but for now I think its ok like that.
If I implement the event part I probably use https://github.com/detached/gorocket, but currently two things in gorocket are missing:
The logo looks good on me. Did you look at the logo in Github and didn't see the scrollbar under the picture?
Hah, sorry about that, you're right about the logo! LGTM!
Add hive which allows to send messages into a Rocket.Chat channel.