search

muesli / cache2go

Concurrency-safe Go caching library with expiration capabilities and access counters
Other
2.12k stars 514 forks source link

I think there are something unreasonably #13

Open qwb492859377 opened 7 years ago

qwb492859377 commented 7 years ago

this is my fork diff :https://github.com/qwb492859377/cache2go/commit/87ff22ffdbcaf9e4f808793847db5557b85ec596

I think in addInternal() function, it should compare the timer start time, not duration time.

muesli commented 7 years ago

I agree, a timer would be a lot nicer here. Would you mind opening a proper pull request for your proposed changes?

qwb2333 commented 7 years ago

I use my new account which pull requests.And after I will use this account along.

vaibhavsanap commented 3 years ago

HI @muesli , Can I work on this.

muesli commented 3 years ago

@vaibhavsanap Of course!