Closed trapajim closed 5 years ago
Nice contribution, thank you!
Awesome, thanks for updating. One more thing occurred to me in the meantime though:
this could lead to breaking existing clients, if they relied on the behavior of the old callbacks being overwritten.
Here's an idea: how about we keep the set*Callback
methods overwriting the entire list of callbacks, and add new add*Callback
methods for the new functionality?
Awesome, thanks for updating. One more thing occurred to me in the meantime though:
this could lead to breaking existing clients, if they relied on the behavior of the old callbacks being overwritten.
Here's an idea: how about we keep the
set*Callback
methods overwriting the entire list of callbacks, and add newadd*Callback
methods for the new functionality?
That makes sense, I didn't think about that. I'll implement that soon.
@muesli just checking in if you saw the changes
@trapajim I'm terribly sorry, it seems I have indeed missed that notification! Thanks for your contributions, really appreciated!
i've added a simple fifo queue for the callbacks. requested in #19