search

muesli / telephant

A lightweight but modern Mastodon client for the desktop
MIT License
190 stars 14 forks source link

Add MacOS Bundle Assets #38

Closed CalmBit closed 4 years ago

CalmBit commented 5 years ago

Still a work in progress, but it's coming along :)

Sorry about the non-atomicity of the gitignore change - I at the least committed it separately, but can reverse it if you'd like!

nueh commented 5 years ago

Sorry, but your .icns file comprises only one icon instead of ten in different sizes and in your Info.plist 


<key>NSHighResolutionCapable</key>
<true/>
<key>NSSupportsAutomaticGraphicsSwitching</key>
<true/>```
are missing.

This file contains all ten albeit automatically converted icons

CalmBit commented 5 years ago

Good job catching that! I don't use icns a lot, as you might have guessed ^^"

muesli commented 4 years ago

@CalmBit I wonder why I never merged this. Looks good to go? I guess I was just waiting for your OK since you mentioned it being a work-in-progress.

CalmBit commented 4 years ago

I'm not exactly sure either, apart from the fact that I was unsure about the format and still seeing how it worked. It should be fine though, thanks to @nueh 's contribution. I'd greenlight it!