search

muesli / telephant

A lightweight but modern Mastodon client for the desktop
MIT License
190 stars 14 forks source link

Pleroma support #65

Open tachiniererin opened 4 years ago

tachiniererin commented 4 years ago

This is the beginning of support for some pleroma specific features. It's still very much WIP, but notifications for emoji reactions are working for now. I also intend to upstream the go-mastodon changes still and i hope they won't be out of scope ^^

My plan is to also show the reactions in the toots like they are shown in pleroma-fe and to add some form of emoji picker to make it possible to react to toots. Though the emoji-picker would probably be best suited for a separate PR, because it's a more generic component and should also support the emoji-packs and not just unicode.

Misskey technically also supports reactions, but i need to have a look as to how it would be done in regard of API support. Another point is that I also want to integrate Mastodon reactions into this, because they're basically a very limited subset of the emoji reactions feature.

muesli commented 4 years ago

Love all the changes! We probably need to rebase this, as I've just merged #64.

muesli commented 4 years ago

Note: I believe TravisCI fails here, because your go-mastodon fork isn't part of go.mod / go.sum. Still need to verify that, though.

muesli commented 4 years ago

Ignore what I wrote above, that's obviously nonsense as we're not using Go modules in Telephant yet. Investigating locally.

muesli commented 4 years ago

Ah, here is the actual error:

accounts/mastodon/mastodon.go:693:56: n.Emoji undefined (type *mastodon.Notification has no field or method Emoji)

It looks like it fails here (and on the CI) because the files in the root of your go-mastodon fork still import sub-packages from the canonical URL (mattn/go-mastodon) and hence we don't include all of your changes. We could work around this in various ways, but I suppose upstreaming your changes would indeed be the nicest solution. :smiley:

Apart from that I think I need to lower the verbosity of that TravisCI output (and maybe switch to GitHub actions while I'm at it).