Closed Cookie-Monster-Coder closed 2 years ago
fyi it's preferred if PRs are done from branches instead of master. This way it allows for easy rebasing when incorporating upstream changes. No worries here though since the only changes you've made to your fork are for this PR. But if you plan on contributing more, using a branch is preferred.
fyi it's preferred if PRs are done from branches instead of master.
Sorry, I'm still new to this. Forgive me for all the spam.
I separate the Scanner and Skipper, I think that would be the best. One for the error handling as stated above and second if someone wanted to run the 'Skipper' alone or vice versa for some reason.
Added a parameter chat for docker variables. Updated docker run commands Added docker compose for the scanner & skipper
fyi it's preferred if PRs are done from branches instead of master.
Sorry, I'm still new to this. Forgive me for all the spam.
Oh no worries, and thanks for putting the time in to set this up! It definitely wouldn't have happened for a while otherwise 🙂
I separate the Scanner and Skipper, I think that would be the best. One for the error handling as stated above and second if someone wanted to run the 'Skipper' alone or vice versa for some reason.
Added a parameter chat for docker variables. Updated docker run commands Added docker compose for the scanner & skipper
Looks good! I think that approach does cover the most use-cases and potential issues
BTW you need to make the two packages public.
Thanks, I didn't know about that. Done!
idk if you want to have the
jellyfin.py
andjellyfin_auto_skip.py
running in the same docker container or different. I think we should put the output ofjellyfin.py
in another dir called/config
so we are able to mount it easily, while keeping all the *py in/app