mueslimak3r / tv-intro-detection

This project tries to detect intros of tv series by comparing pairs of episodes to find the largest common subset of frames.
https://mueslimak3r.github.io/tv-intro-detection/
GNU General Public License v3.0
81 stars 3 forks source link

Create Docker image. Build and push to ghcr.io/mueslimak3r/tv-intro-detection:latest #1

Closed Cookie-Monster-Coder closed 2 years ago

Cookie-Monster-Coder commented 2 years ago

idk if you want to have the jellyfin.py and jellyfin_auto_skip.py running in the same docker container or different. I think we should put the output of jellyfin.py in another dir called /config so we are able to mount it easily, while keeping all the *py in /app

mueslimak3r commented 2 years ago

fyi it's preferred if PRs are done from branches instead of master. This way it allows for easy rebasing when incorporating upstream changes. No worries here though since the only changes you've made to your fork are for this PR. But if you plan on contributing more, using a branch is preferred.

Cookie-Monster-Coder commented 2 years ago

fyi it's preferred if PRs are done from branches instead of master.

Sorry, I'm still new to this. Forgive me for all the spam.

I separate the Scanner and Skipper, I think that would be the best. One for the error handling as stated above and second if someone wanted to run the 'Skipper' alone or vice versa for some reason.

Added a parameter chat for docker variables. Updated docker run commands Added docker compose for the scanner & skipper

mueslimak3r commented 2 years ago

fyi it's preferred if PRs are done from branches instead of master.

Sorry, I'm still new to this. Forgive me for all the spam.

Oh no worries, and thanks for putting the time in to set this up! It definitely wouldn't have happened for a while otherwise 🙂

I separate the Scanner and Skipper, I think that would be the best. One for the error handling as stated above and second if someone wanted to run the 'Skipper' alone or vice versa for some reason.

Added a parameter chat for docker variables. Updated docker run commands Added docker compose for the scanner & skipper

Looks good! I think that approach does cover the most use-cases and potential issues

Cookie-Monster-Coder commented 2 years ago

BTW you need to make the two packages public.

mueslimak3r commented 2 years ago

Thanks, I didn't know about that. Done!