GTK4+libadwaita port, many layout fixes, etc

mufeedali / Wordbook

Wordbook is a dictionary application built for GNOME.

GNU General Public License v3.0

92 stars 15 forks source link

GTK4+libadwaita port, many layout fixes, etc #27

Closed mufeedali closed 2 years ago

mufeedali commented 3 years ago

Closes #26

mufeedali commented 3 years ago

This is for GNOME Circle.

To-do:

[x] Improve history and implement history persistence
[x] Specify supported language in metadata
[x] Increase preferences window default width
[x] Add tooltips for HeaderBar buttons
[x] Add a tooltip for pronunciation button
[x] Anchor scrollbar to right
[x] Add i18n support
[x] Clamp search bar width

Unsure about:

[x] ~Remove search button and default to live search~ Now defaults to live search and hides search button when in live search.

mufeedali commented 3 years ago

Other work:

[x] Improve project structure
[x] Use devel builds by default
[x] Use GLib where necessary
[x] Improve documentation, both within code and outside
[x] Make custom definitions more obscure
[x] Less and less hardcoding
[x] Improve strings where possible
[x] ~Fix completions only being shown when there is at least 10 available completions. Also prepare completions for migration to GTK4.~ ~Seems like it's impossible for now.~ Fixed.
[x] Complete work on restructuring how results are formed.
[x] Improve HeaderBar spacing
[x] Fix a bug where first word in word lists (like synonyms, similar to, etc) are not colored appropriately.

mufeedali commented 3 years ago

Defaulting to live search is troublesome because then the matter of how and when to present completions and when to hide them comes up. So that needs some additional thought.

mufeedali commented 3 years ago

So... umm... I'm porting to GTK4 + libadwaita now because there's a lot of stuff that would get simpler if I did that. There's some functionality that would be lost too, but hopefully they'll be back soon.

sophie-h commented 3 years ago

@fushinari feel free to join #app-dev:gnome.org on Matrix if you need help with porting your app or want feedback for design decisions :)

mufeedali commented 3 years ago

Joined! Thanks for letting me know! :)

mufeedali commented 3 years ago

What's still broken (GTK4, in order of priority):

~Completions: actions seem to be gone from GTK4. I can't abuse them anymore. Either remove completions and replace with another mechanism, or find a way to give a custom list to EntryCompletion.~ Fixed. Missing the italic indicator for custom definitions. But that's a non-blocker since custom definitions isn't really an exposed feature.
~Type to search: (i.e. type anywhere, without the searchentry needing to be focused). Should be possible if using GtkEntry. But using GtkEntry has led to issues, so will need to look into it.~ Fixed.
~Double click to search: I haven't looked into it enough.~ Fixed.
~Zombie process: wordbook leaves a zombie process if GLib.idle_add(self._search_entry.grab_focus) is called during its runtime.~ Fixed.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 33a95cf4c4a9a29caa80c71067f913d445c65172 into ba45fe7aa08aae875dd13313bcc2256fed0fb0f9 - view on LGTM.com

new alerts:

1 for Unused local variable

mufeedali commented 3 years ago

Pending tasks:

[x] Fix bugs mentioned above
[x] Update to use wn 0.9.0 when it arrives.
[x] Add a retry button to the network error page.
[x] Use AdwStatusPage for download progress.
[x] Remove dark font switch and use AdwStyleManager to accurately identify dark mode and switch accordingly.
[x] Maybe more? I'm not sure.