mufeedvh / basecrack

Decode All Bases - Base Scheme Decoder
MIT License
526 stars 91 forks source link

a base32 bug #12

Closed Nixiabing closed 3 years ago

Nixiabing commented 3 years ago

[-] Encoded Base: MZWGCZ33GQZTQMTEM5SGMMTEPU=====

[!] Not a valid encoding.

mufeedvh commented 3 years ago

Hey @Nixiabing, first of all sorry for the late response. :raised_hands:

Thank you for raising this issue, the bug was that the inbuilt base32 charset in Python doesn't follow this charset spec and will result in an Incorrect padding error. A fix (https://github.com/mufeedvh/basecrack/commit/86f8ec7a713e269be116a9063a19f307222e1d6d) has been applied with the implementation of RFC 3548 charset where the padding is stripped while decoding for handling both cases. :+1:

Screenshot from 2021-06-17 07-09-44

Again, thank you raising this issue. :heart::raised_hands:

Nixiabing commented 3 years ago

Thank you~