search

mufeedvh / basecrack

Decode All Bases - Base Scheme Decoder
MIT License
534 stars 91 forks source link

A suggestion #23

Open vu1Art1st opened 1 year ago

vu1Art1st commented 1 year ago

In file base_chain.py line 88, I suggest to change the code base64.b16decode(encoded_base, casefold=False).decode('utf-8', 'replace') to base64.b16decode(encoded_base.upper(), casefold=False).decode('utf-8', 'replace')

berwil-1 commented 1 month ago

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

vu1Art1st commented 1 month ago

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

Sry, I didn't view the whole code.This suggestion just try to resolve an error when decoding lower case base32, for this i just add ".upper()"