search

muffinmad / emacs-mini-frame

Show minibuffer in child frame on read-from-minibuffer
GNU General Public License v3.0
321 stars 20 forks source link

isearch support? #82

Closed katspaugh closed 9 months ago

katspaugh commented 9 months ago

I saw the mini-frame was disabled for isearch-mode in this commit.

Would it be possible to bring it back in and fix #48 in a cleaner way? Perhaps it could be added to the ignored commands instead, so that it's customizable?

I tried reverting that commit locally but somehow isearch is still not popping up a mini-frame. Looking at the isearch code, it seems to be using the read-from-minibuffer function, so it should theoretically work?

muffinmad commented 9 months ago

isearch is using read-from-minibuffer on isearch-edit-string. Press M-e after C-s and you should see mini-frame.

katspaugh commented 9 months ago

I see, thanks a lot. Awesome plugin!