muffinmad / emacs-mini-frame

Show minibuffer in child frame on read-from-minibuffer

GNU General Public License v3.0

321 stars 20 forks source link

kill-buffer prompt gets truncated oddly #86

Closed n-hebert closed 6 months ago

n-hebert commented 6 months ago

Install & Config

  (use-package mini-frame
    :config
    (setq mini-frame-resize nil)
    (mini-frame-mode +1)
    (custom-set-variables
      '(mini-frame-show-parameters
         '((top . 0.3)
           (width . 0.5)
           (left . 0.5)
           (height . 10)))))

Steps to reproduce

Open a buffer
Type some text
C-x k and select this buffer

Expected Result

It shows the prompt to the user: "Buffer $BUFFER modified; kill anyway?" etc etc

Actual Result

It says yway? (yes/no/save and then kill) and it's a little confusing. A user can't really answer.

muffinmad commented 6 months ago

What is completion package used in screenshot? How the prompt looks like with mini-frame mode turned off and with Emacs frame smaller width?

n-hebert commented 6 months ago

That would be selectrum, and here it is without mini-frame mode:

Good thinking! So it seems to be related to selectrum and the window width, not strictly mini-frame :open_mouth:

Any tips? I can go file an issue over there, if that sounds like the best plan of action. Cheers

n-hebert commented 6 months ago

p.s. For now increasing the width of the mini-frame is indeed a work-around for this particular prompt. A more general solution would require a code change, of course, on emacs itself, mini-frame, or selectrum.

muffinmad commented 6 months ago

I think it should be handled in selectrum itself. Emacs shows the full prompt.

n-hebert commented 6 months ago

Sounds good, I'll file something over there. Cheers!