Sweep: Fix logic error in update a book by id endpoint

[mufidu]

Details

In update a book by id endpoint in routes/book.routes.js, there can be a problem in database and the server will still send 404 error, but that doesn't seem right, because then it should be database error. Fix that.

Checklist

- [X] Modify `routes/book.routes.js` ✓ https://github.com/mufidu/booku/commit/6cdc0c328c6d4810b7c9e7f8ca8d91553ebefd47 [Edit](https://github.com/mufidu/booku/edit/sweep/fix_logic_error_in_update_a_book_by_id_e/routes/book.routes.js) - [X] Running GitHub Actions for `routes/book.routes.js` ✓ [Edit](https://github.com/mufidu/booku/edit/sweep/fix_logic_error_in_update_a_book_by_id_e/routes/book.routes.js)

[sweep-ai[bot]]

🚀 Here's the PR! #141

See Sweep's progress at the progress dashboard!

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 90595e99ed)

---

[!TIP] I can email you next time I complete a pull request if you set up your email here!

---

Actions (click)

• [ ] ↻ Restart Sweep

---

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/mufidu/booku/blob/ed3223df43d7f247e4af4026c11c25eba0c5e881/routes/book.routes.js#L1-L103

---

Step 2: ⌨️ Coding

• [X] Modify routes/book.routes.js ✓ https://github.com/mufidu/booku/commit/6cdc0c328c6d4810b7c9e7f8ca8d91553ebefd47 Edit

  Modify routes/book.routes.js with contents:
  • Locate the "update a book by id" endpoint, which starts with `router.put('/:id', async (req, res) => {`.
  • Inside this endpoint, wrap the `Book.findByIdAndUpdate` method call in a try-catch block.
  • In the try block, place the existing `Book.findByIdAndUpdate` call along with its subsequent logic for checking if the book exists (`if (!book) { ... }`) and sending the book as a response (`res.json(book);`).
  • In the catch block, respond with a 500 Internal Server Error status and a message indicating a database error. For example, use `res.status(500).json({ message: 'Database operation failed', error: e.message });`.
  • This modification ensures that if the `Book.findByIdAndUpdate` method throws an error, it is caught, and an appropriate server error response is returned instead of incorrectly returning a 404 error.

--- 
+++ 
@@ -49,15 +49,19 @@
     const { id } = req.params;
     const { title, author, year, category, cover } = req.body;

-    const book = await Book.findByIdAndUpdate(id,
-        { title, author, year, category, cover },
-        { new: true },);
+    try {
+        const book = await Book.findByIdAndUpdate(id,
+            { title, author, year, category, cover },
+            { new: true });

-    if (!book) {
-        return res.status(404).send("Book not found");
+        if (!book) {
+            return res.status(404).send("Book not found");
+        }
+
+        res.json(book);
+    } catch (e) {
+        res.status(500).json({ message: 'Database operation failed', error: e.message });
     }
-
-    res.json(book);
 });

 // Delete a book by id

• [X] Running GitHub Actions for routes/book.routes.js ✓ Edit

  Check routes/book.routes.js with contents:

Ran GitHub Actions for 6cdc0c328c6d4810b7c9e7f8ca8d91553ebefd47:

---

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/fix_logic_error_in_update_a_book_by_id_e.

---

🎉 Latest improvements to Sweep:

• New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
• Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
• Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. ^{Something wrong? Let us know.}

This is an automated message generated by Sweep AI.