Sweep: Fix using property from null object

[mufidu]

Details

Here is the error log:

/Users/mufid/repos/booku/app.js:55
    console.log(book.title);
                     ^

TypeError: Cannot read properties of null (reading 'title')

Checklist

- [X] Modify `app.js` ✓ https://github.com/mufidu/booku/commit/a28e2ccc67439255aa422b25fdb0e561049af38f [Edit](https://github.com/mufidu/booku/edit/sweep/fix_using_property_from_null_object/app.js) - [X] Running GitHub Actions for `app.js` ✓ [Edit](https://github.com/mufidu/booku/edit/sweep/fix_using_property_from_null_object/app.js)

[sweep-ai[bot]]

🚀 Here's the PR! #47

See Sweep's progress at the progress dashboard!

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 0459c5fbb8)

---

[!TIP] I can email you next time I complete a pull request if you set up your email here!

---

Actions (click)

• [ ] ↻ Restart Sweep

---

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/mufidu/booku/blob/dabafdde6f2cc742d8753c9120e05a33f24904be/app.js#L50-L60

---

Step 2: ⌨️ Coding

• [X] Modify app.js ✓ https://github.com/mufidu/booku/commit/a28e2ccc67439255aa422b25fdb0e561049af38f Edit

  Modify app.js with contents:
  • At line 54, right after fetching the book from the database using `Book.findById(req.params.id)`, add a conditional check to verify if the book exists.
  • If the book does not exist (`if (!book)`), return a response with a 404 status code and a JSON object containing an error message, e.g., `res.status(404).json({ message: 'Book not found' })`.
  • This check should be placed before attempting to log the book's title or sending the book as a response to ensure the server does not attempt to access properties of a null object.
  • The rest of the function remains unchanged, as it correctly handles the case when the book exists.

--- 
+++ 
@@ -52,6 +52,9 @@
 // Get a book by id
 app.get("/books/:id", async (req, res) => {
     const book = await Book.findById(req.params.id);
+    if (!book) {
+        return res.status(404).json({ message: 'Book not found' });
+    }
     console.log(book.title);
     res.json(book);
 });

• [X] Running GitHub Actions for app.js ✓ Edit

  Check app.js with contents:

Ran GitHub Actions for a28e2ccc67439255aa422b25fdb0e561049af38f:

---

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/fix_using_property_from_null_object.

---

🎉 Latest improvements to Sweep:

• New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
• Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
• Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. ^{Something wrong? Let us know.}

This is an automated message generated by Sweep AI.