search

mugifly / jquery-simple-datetimepicker

Date & time picker for jQuery, It's simple & clean.
http://mugifly.github.com/jquery-simple-datetimepicker
Other
260 stars 182 forks source link

External locale #161

Closed royzrj closed 8 years ago

royzrj commented 8 years ago

If the library is used in an environment that does not support UTF-8, some pre-configured locales do not work as intended. The external_locale object enables the library use without modifications.

royzrj commented 8 years ago

I understand this modification requires updating the Wiki, explaining it's use. @mugifly if you feel this pull is ok feel free to contact me to update the Wiki

mugifly commented 8 years ago

Thank you for your commits :)

It seems nice opinion! But I think the external_locale object should be given as child of the config object as follows.

$(function(){
    $('#date').appendDtpicker({
        locale: 'foo',
        externalLocale: {
            foo: {
                days: [],
                months: [],
                sep: '...',
                format: '...'
            }
        }
    });
});

What do you think for my opinion?

By the way... the options page of wiki isn't update recently. Because it is duplicated effort with updating the examples page (jquery.simple-dtpicker.html). So, please update the examples page in the repository, for now. I apologize for that confusion. And thank you.

royzrj commented 8 years ago

@muglify nice, will modify the code as of now

mugifly commented 8 years ago

Thanks :+1: