search

mugifly / jquery-simple-datetimepicker

Date & time picker for jQuery, It's simple & clean.
http://mugifly.github.com/jquery-simple-datetimepicker
Other
259 stars 181 forks source link

Improved localization by replacing local depended code #73

Closed LucasTheCure closed 11 years ago

LucasTheCure commented 11 years ago

Added translation mechanism. All translatable strings ware moved to lang config object . This change improve portability to other languages, made it more readable and compact. Language depended ifs in logic body code have been removed and placed in config.

mugifly commented 11 years ago

@LucasTheCure Thank you, LucasTheCure. Firstly, I'm really sorry for the late reply.

I merged some commit from your commits, into master branch.

However, you should that new feature ("min and max values for time selector" 2c1fa35d14e40202f160e190de7b1cf3941bf063) is separated as another Pull-Request. I was wondering if you could make a Pull-Request again. (It's more better if that source-branch is besides your master branch.)

And... In this library script, I think want to keep a header-comment as simple and short. So, your repository url has stripped when push to the master branch. Instead it, I added your url to the documents. Thank you for your understanding.