search

mugishasam123 / Task-tracker

this todolist was built with plain javascript to assess the skills of javscript best practices,classes,modules etc
https://mugishasam123.github.io/todoList-Javascript/
1 stars 0 forks source link

Peer feedback Js best practices. #4

Open billionsjoel opened 2 years ago

billionsjoel commented 2 years ago

  1. You have a good readme file although I suggest you add a link to a live demo as it is required.

  2. When writing committing messages, I think it is a good common practice to use a capital letter of the verb while beginning the sentence.

  3. I have realised that all your commit messages are the same and this could be quite confusing.

  4. Good use of functional code although I think in this case scenario it was really unnecessary as you could implicitly save the returned array to the variable directly. Screenshot 2022-01-17 at 11 02 13.

  5. Your save function definition on line 20 does not specify any parameter ,

    Screenshot 2022-01-17 at 11 06 17

    but in the function call you are passing an argument. could you please explain what is happening?

    Screenshot 2022-01-17 at 11 06 58

  6. Good use of local storage but don't you think you ar repetitively get data from the local storage on almost every function call which could have an implication on app speed? i suggest you optimise that and only call it once then reuse that call.

Screenshot 2022-01-17 at 11 14 23
mugishasam123 commented 2 years ago

sure @billionsjoel I will work on the issues you stated and will let you know when I am done

mugishasam123 commented 2 years ago

Thank you for noting out the issues but surely I fixed them