A couple patches

[GoogleCodeExporter]

commit d95a02ff2aa2ec5d6c6d392b86c9ffe2ef99adb5
Author: Adeodato Simó <dato@net.com.org.es>
Date:   Tue Oct 20 01:21:45 2009 +0100

    Redefine SCROBBLE_MODE_PLAYED as "", provide SCROBBLE_MODE_LOVED as "L".

    The 'L' rating is only to be used if the user has manually loved the
    track. For a normal play, the documentation clearly says that the rating
    should be the empty string.

commit 6f04ee43f8829c8ecefcc03379f20e1b5fa9f286
Author: Adeodato Simó <dato@net.com.org.es>
Date:   Tue Oct 20 01:21:08 2009 +0100

    Fix reference to undefined variable in Track._remove_tag().

Original issue reported on code.google.com by dato.simo@gmail.com on 20 Oct 2009 at 12:37

Attachments:

• 0001-Fix-reference-to-undefined-variable-in-Track.remove.diff
• 0002-Redefine-SCROBBLE_MODE_PLAYED-as-provide-SCROBBLE_MOD.diff

[GoogleCodeExporter]

Loved means it was played. It's an old protocol, the web services 2.0 did not 
exist
thing and the love action was done through the scrobbling protocol.

Original comment by amr.hassan on 21 Oct 2009 at 12:45

• Changed state: Invalid

[GoogleCodeExporter]

Sorry, let me clarify. The scrobbler in pylast uses the 1.2.1 version of the 
protocol 
(that is, it sends p="1.2.1" it its requests). In the documentation of that 
version 
protocol (http://www.last.fm/api/submissions), it says:

  r[0]=<rating>

  A single character denoting the rating of the track. Empty if not applicable.
  L - Love (on any mode if the user has manually loved the track). This implies a 
listen.

That clearly means that 'L' is only to be used if the user has **manually 
loved** the 
track. Of course, that implies a listen, but that does not mean that every 
listen 
should imply a 'L'! It also says that, for normal plays (i.e., not loved or 
banned), 
it should be empty.

Is this explanation clearer? I hope so, if you still think I'm wrong I suggest 
you 
ask in the Last.fm API group, pointing to this bug. Or I can do that for you. 
:-)

Thanks for your work on pylast!

Original comment by dato.simo@gmail.com on 21 Oct 2009 at 10:02

[GoogleCodeExporter]

I was missing something, the rating can be left out blank. Setting the
rating to L or B does not set the loved or banned status without
calling the webservice methods, so I was using the L rating because it
was simply harmless.

Original comment by amr.hassan on 21 Oct 2009 at 10:47

[GoogleCodeExporter]

Excellent, thank you very much.

Original comment by dato.simo@gmail.com on 21 Oct 2009 at 12:30