search

muhamedzeema / appgallery-deply-action

6 stars 7 forks source link

Add file-name input property for preventing hardcoded file name #5

Closed dinisnunes1 closed 2 years ago

dinisnunes1 commented 2 years ago

Problem: The APK (or other AAB) is always being uploaded as app-release.apk file name, and that's the name that is visible on AppGallery. Issue: https://github.com/muhamedzeema/appgallery-deply-action/issues/4

Solution: Created an optional input type (file-name) in this Github Action so we could define a desired file-name. Example:

- name: Deploy to Huawei App Gallery
  uses: muhamedzeema/appgallery-deply-action@main
  with:
    client-id: ${{secrets.HUAWEI_CLIENT_ID}}
    client-key: ${{secrets.HUAWEI_CLIENT_KEY}}
    app-id: ${{secrets.HUAWEI_APP_ID}}
    file-extension: "apk"
    file-path: "apk/release/app-release.apk"
    file-name: "MyAppName-1_0_0"
    submit: true

Tests: Tested with and without the file-name input and it's working as supposed.

With file-name: "MyAppName-1_0_0"

MyAppName_appgallery

Without file-name input

app-release_appgallery
muhamedzeema commented 2 years ago

merged, thank you for your contribution @dinisnunes1 🎉✌️