Open muhammad-faruq opened 3 years ago
The intention is to make the programme optimized for CLI. Should a user want to switch tabs, they typically are going to execute commands through the CLI. Also, the user might toggle to the tab just to view the information but accidentally enter commands meant for the wrong tab. Having the user explicitly toggle with the CLI helps them be more aware of the tab that is active. As the menu bar contains information that navigates outside of the app, having interactable elements does not hamper the user's CLI experience.
Team chose [response.Rejected
]
Reason for disagreement: Hi devs,
While it holds true that you need to optimize this application for CLI users, it does not make any sense from a design standpoint to include tabs in an application that clearly can be switched but you cannot click on it to switch between tabs. This is similar to saying that we have the 'X' button on the top right of the application but you cannot click on that button to close the app but rather you can only do so by typing the exit
command. This simply makes no sense at all as you are clearly leaving out features that should very clearly be there. This MUST be considered a bug as it would only make sense for users to be able to click the tabs and expect it it to change to the clicked tab.
On the point of fearing that the user enters a command for the wrong tab, I do not believe that this is an issue in any way. The current behavior is that the user needs to change to whichever tab they please by using the toggle
command and then whatever commands such as add
or delete
will be done on the active tab. There is no difference in behavior and it is in no way less intuitive for the user to switch tabs by clicking on it followed by using the commands to affect the active tabs. Hence this explanation as to why the onClick method of the tab is not implemented is not valid. Furthermore, this feature can easily be implemented by setting an onClick method that will also change the toggle
status of the tabs.
After much deliberation, I realize that this in fact affects ALL users and will cause occasional inconvenience to them as it is only natural to expect the users to believe that the tabs are clickable. Having tabs shown there which will be highlighted on toggle
but not switchable by clicking simply will seem as though the application is incomplete and it was just released with a feature clearly left out. I believe that this is in fact FeatureFlaw
with Severity: Medium
.
Refer to screenshot below on the Module Website for how this is Severity: Medium
Thank you.
The main panel has clear tab windows which show Patients and Doctors. However the tab panels are not clickable and are can only be toggled by using the command
toggle
.This is a feature flaw as intuitively if we have such GUI like a menu bar, it would only be logical that clicking on the tab will allows us to move the the selected tab.