nus-pe-bot
commented
2 years ago Team's Response
This is an intended design. Edit command is meant to be used to edit data fields such as names, email addresses and phone numbers. Remarks are texts and sentences rather than data fields, hence we felt it was more suitable to create a separate command for it. Furthermore, this will improve the product because it allows the user to easily edit remarks through an independent command instead of coupling the functionality with the edit patient commands and needlessly clutter the possible fields that the commands can take. Also, since the remark would likely be updated frequently to reflect patients’ current status, having a separate command allows the clinic receptionist to edit remarks more efficently.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Hi devs,
Attached is a screenshot of a person card. Here we can see the different data fields that a person have. From the screenshot above, it would be natural for the user to believe that the remarks is in fact just another attribute to a person similar to all the other attributes there are. Hence this will then result in the user thinking that they would be able to change remark together with edit as edit can change EVERYTHING about a person. We also notice that there is a tag command that can change the tag separately but edit also supports the changing of tags. This brings about even more inconsistency as we have separate commands but a similar functionality in the edit command for TAG. But for remarks we only have a separate command but no similar functionality in the edit command to change the remarks field. This is a DesignFlaw as if we wanted it to be clear that remarks is a separate field, then it should be made clearer in the UI that it is in fact not to be lumped together with all other data fields of a person. Hence I still believe that this is a FeatureFlaw.
Every single attribute of the person can be edited by using the edit command. However the remark of a person is not able to be edited using the edit command and a special remark command is needed for this case. This is rather unintuitive for the user as there is not special reason for there to be a remark command.
Perhaps it would be better to integrate the remark command together with edit to make the usage more intuitive.