muhammad-faruq / pe

0 stars 0 forks source link

Poor choice of sample data #4

Open muhammad-faruq opened 2 years ago

muhammad-faruq commented 2 years ago

image.png

image.png

Only the first names of the sample data is changed from patients to doctors. All the other data such as phone number dob email are all exactly the same. It would be better to have completely separate people and in that aspect data for doctors and patients.

nus-pe-bot commented 2 years ago

Team's Response

This is just a sample data, it is not meant to be used for any official purposes but for teaching purposes. The fact that the names are different are sufficient for the purpose of the sample data. If you would like to clear the data and start again, we also provided a clear command to do that.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Sample data should be representative of the data that could be placed in the application. While it is indeed dummy data, it should not be clear copy paste of the data from the other tab. We can clearly see that the patient tab was created before the doctors tabs through the remarks column. Doctor Alex Yeoh has the remark "Prefers Dr. Lau" (ooh scandalous >w<) and Doctor Charlotte Oliveiro has the remark "Only understands Mandarin" All of these are remarks for patients and are clearly not representative of a Doctor Entry. Hence this is a FeatureFlaw due to a simple copy paste of sample data without putting in consideration to change important fields such as remarks.