muhammad-faruq / pe

0 stars 0 forks source link

Change of format for date of birth #6

Open muhammad-faruq opened 2 years ago

muhammad-faruq commented 2 years ago

image.png

The date of birth that is keyed in by the user is in the format dd/mm/yyyy while in the name card it is displayed as yyyy-mm-dd

It would be better to be consistent.

nus-pe-bot commented 2 years ago

Team's Response

This is an intended design. When a user inputs the date, entering the format as "dd/mm/yyyy" makes sense as that is how most people are used to writing dates.

On the other hand, when birth dates are displayed, we felt it made more sense to put the year first when displaying the birth date. This is because the year is the most important information in a birth date and since words are read from left to right, we felt it made sense to put the year of the birth date on the right.

Furthermore, this is just a cosmetic issue, hence the severity of the bug is also wrong.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If a certain way is more intuitive than another then it should be consistently in that manner. It does not make sense for the input date to change from one format to another so drastically. If it is a matter of formatting change from 02/07/2021 to 2-Jul-2021 then I can understand where this is coming from but the format change was from dd/mm/yy to yy-mm-dd which makes no sense at all to do such a thing. I still believe that this is a FeatureFlaw as if we want to change it to a certain format we should be consistent to stick to such a format. A user seeing how the date is being saved may have the assumption that the command date should be stated in a similar way which is not the case. Hence this lack of consistency is in fact an inconvenience to the user.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Since the lack of consistency is an inconvenience to the user rather than just a cosmetic flaw, it should remain as Severity:Low.