search

muhammad-faruq / pe

0 stars 0 forks source link

Invalid inputs for DOB is accepted as valid #7

Open muhammad-faruq opened 3 years ago

muhammad-faruq commented 3 years ago

edit 1 dob/0000000000000001/01/0000

is considered as an accepted command]

However for whatever reason when prepending more zeros to the front, this will eventually break and say that the dob is not valid

edit 1 dob/00000000000000001/0000000000000000000001/0000

is not valid.

Besides that, it is allowed for the input to be absurd in the sense that the age of the person can be 2000.

nus-pe-bot commented 2 years ago

Team's Response

The user will not input commands like edit 1 dob/0000000000000001/01/0000 or edit 1 dob/00000000000000001/0000000000000000000001/0000 in a real usage where they follow the user guide and the sample commands given. This can only happen in a case of a deliberate sabotage.

image_2021-11-14_16-11-59.png

It is not on us to limit the age of the person. It is the onus of the users to decide what the age of the person added is. Perhaps the clinic has been running for generations, and there are some patient records where their date of birth is in the 1800s as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]