search

muhammad-faruq / pe

0 stars 0 forks source link

Not supported for names with "/" #9

Open muhammad-faruq opened 2 years ago

muhammad-faruq commented 2 years ago

Names such as Rama s/o Ramu is not supported for this application.

edit 1 n/Rama s/o Ramu will say that the name is invalid.

In this case there is no way to present such a name except for using "so".

nus-pe-bot commented 2 years ago

Team's Response

This is an intended behaviour as names only accept alphanumeric characters. It is clearly stated in the user guide and error message. "\" is not an alphanumeric character. We only allowed alphanumeric characters in the name, so as to prevent users from abusing the name data fields.

If a user really wants to enter "s/o', he can enter it as "SO" or"son of", where the meaning of the name is still clear.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: s/o is a very common occurrence in people's name. Not allowing users to input proper common names into the system is in fact a FeatureFlaw. If anything it can be further considered as Overzealous input validation as the program seems unnecessarily restrictive to the general public. So would you also say that suppose the capital letter "I" may be causing bugs in your program so we don't allow users to use the letter "I" and instead for all their names just use the small letter "l" instead as it looks the same? The onus is on the developer to allow common names to be keyed in and not take shortcuts to make things easier for them and harder for the users.