search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
113 stars 11 forks source link

Publishing extension workflow is not working #21

Closed muhammadsammy closed 2 years ago

muhammadsammy commented 3 years ago

https://github.com/muhammadsammy/free-omnisharp-vscode/actions/runs/1027459863

https://github.com/muhammadsammy/free-omnisharp-vscode/blob/860834fb7abfa76047a8a9a8a40c3a5422f9ca30/.github/workflows/publish.yml

pm4rcin commented 2 years ago

@muhammadsammy the logs aren't available so it's not possible to troubleshoot.

muhammadsammy commented 2 years ago

I will update the extension and new logs will be available and I will share them here

muhammadsammy commented 2 years ago

https://github.com/muhammadsammy/free-omnisharp-vscode/runs/4912860620?check_suite_focus=true the error that happens now is different from the one before, the problem was the ci cannot find the vsix file to upload to OpenVSX on this step: https://github.com/muhammadsammy/free-omnisharp-vscode/blob/f213efc9ead4357997f59ebe123c768482766043/.github/workflows/publish.yml#L25

pm4rcin commented 2 years ago

I think it's because release-ci job was not completed before publish. Maybe try re-run publish.

muhammadsammy commented 2 years ago

just tried re-run the action, still the same error

pm4rcin commented 2 years ago

Oh and one more thing. Upstream uses NodeJS 15 so I guess we should update?

muhammadsammy commented 2 years ago

That eleminated the error https://github.com/muhammadsammy/free-omnisharp-vscode/runs/4913046575?check_suite_focus=true I will change the access token and try again

muhammadsammy commented 2 years ago

I think it seems to be fixed. the error from ovsx in the old logs was no such file or directory but now it is extension is already published https://github.com/muhammadsammy/free-omnisharp-vscode/runs/4913072637?check_suite_focus=true#step:8:7 Or should we try to bump version and try to actually publish the extension?

pm4rcin commented 2 years ago

That's strange. If you didn't manually upload to open-vsx then I don't know how it was uploaded. Or did you? Because VSCodium showed an update and looks like it worked. I haven't tested too much but that https://github.com/OmniSharp/omnisharp-vscode/pull/4948/files works which was added with 1.24 release.

muhammadsammy commented 2 years ago

Oh yes I've uploaded it manually just after I merged changes from upstream.

muhammadsammy commented 2 years ago

Or it was automatically found by open-vsx. Maybe they have some bot which scans once in a while for new release?

yes, they have a bot that does this, but not for this repo, I think it's for extensions with no OpenVSX account

pm4rcin commented 2 years ago

I also see that they have changed how they package the extension. I think that it won't be hard to add because that action was successfull. It's probably good idea to pull that changes and bump version like we did before with -PATCH and see if everything works.

muhammadsammy commented 2 years ago

I've tried to pump version, change the gulp command and it was published successfully to OpenVSX: https://github.com/muhammadsammy/free-omnisharp-vscode/runs/4922065591?check_suite_focus=true#step:8:6

I do not know why the vsix file was not being detected before, but it works now Thanks a lot, @pm4rcin!

pm4rcin commented 2 years ago

Great to see it's working! One thing to note is that we should track progress on https://github.com/eclipse/openvsx/issues/336 and make changes to workflows when new release of Omnisharp arrives.

pm4rcin commented 2 years ago

@muhammadsammy open-vsx has merged the platform-specific PR. I think it'd be a good idea to edit CI and check now if it builds before new version of extension is released in the future.

muhammadsammy commented 2 years ago

The release-ci already creates platform-specific vsix files, but we need to modify publish ci to publish multiple platform specific versions