search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
113 stars 11 forks source link

Extension throws `not compatible with VS Code {{version}}` error on install `>= 1.23.11` #23

Closed sar closed 2 years ago

sar commented 2 years ago

Extension throws version compatibility error on VS Code when attempting to install using source built from 5035a145d3d2ad364add5a819abc81fe1dbdb87b, see log message emitted below.

Rolling git tree back to previous commit and building vsix artifact output installs successfully on release version 1.23.11, which no long works due to #20 and #23 dependency failure.

Environment data

dotnet --info

.NET SDK (reflecting any global.json):
 Version:   5.0.400
 Commit:    d61950f9bf

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  18.04
 OS Platform: Linux
 RID:         ubuntu.18.04-x64
 Base Path:   /usr/share/dotnet/sdk/5.0.400/

Host (useful for support):
  Version: 5.0.9
  Commit:  208e377a53

.NET SDKs installed:
  2.1.817 [/usr/share/dotnet/sdk]
  3.1.412 [/usr/share/dotnet/sdk]
  5.0.400 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.29 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.29 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.18 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.9 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.29 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.18 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.9 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download

Code versions tried: 1.56.1 1.57.1 etc C# Extension version: 1.23.14

Log

Unable to install extension 'csharp' as it is not compatible with VS Code '1.57.1'.

[2021-08-13 16:40:42.919] [window] [error] Unable to install extension 'muhammad-sammy.csharp' as it 
is not compatible with VS Code '1.57.1'.: Error: Unable to install extension 'muhammad-sammy.csharp' as 
it is not compatible with VS Code '1.57.1'.
    at /usr/local/share/.config/yarn/global/node_modules/code-server/lib/vscode/out/vs/server
/entry.js:36:61646
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
sar commented 2 years ago

Stems from upstream commit f95264a7abe849a14d23f8af2537d028a145ce40 - ref blame, changes can be reverted locally for installation on unsupported user config, closing issue.

Comment: Bump min ver requirement since previous extension release

https://github.com/muhammadsammy/free-omnisharp-vscode/blob/f95264a7abe849a14d23f8af2537d028a145ce40/package.json#L385-L387