search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
110 stars 10 forks source link

1.23.15-Patch change #28

Closed hm2075 closed 2 years ago

hm2075 commented 2 years ago

Please upload a new version to openvsx, gitpod thinks 1.23.15-patch is older than 1.23.15 and automatically installs the non patch version

i managed to build from source and got the extension plus omnisharp working without issue but new workspaces just download extensions again.

If possibly can you allow 1.57 vs code? self hosted gitpod currently runs on 1.57 unless using nightly build

muhammadsammy commented 2 years ago

I don't want to pump up the version in order to match versions with upstream. Try to disable automatic extension updates in gitpod or vscodium by adding "extensions.autoUpdate": false to the settings.json until a next upstream version released.

hm2075 commented 2 years ago

fair enough :)

thanks

hm2075 commented 2 years ago

I don't think that will work because gitpod downloads extensions each time from open vsx for new workspaces. So you always end up with the latest which in this is always 1.23.15 and not patch

Its not really your extension issue but maybe replace 1.23.15 altogether?

muhammadsammy commented 2 years ago

Unfortunately OpenVSX does not allow removing published versions or replacing them If gitpod allows adding extensions from source, this build artifact should work https://github.com/muhammadsammy/free-omnisharp-vscode/suites/3800587607/artifacts/93838888 it has the extension with correct debugger links and versioned as 1.23.15

hm2075 commented 2 years ago

yes, can build from source and its fine but then each user has to manually install the extension for each new workspace on gitpod

muhammadsammy commented 2 years ago

I can't think of any solution to this except pumping up the version to 1.23.16 but this will not be matching with upstream and since the official omnisharp team just published a prelease of 1.23.16, this issue will be fixed soon

https://github.com/muhammadsammy/free-omnisharp-vscode/commit/76e27ea007b3cca8067a39774d5f0908f19182d0 NetCoreDbg versions will be fixed and updated with each release of this extension in order to avoid this issue in the future

empz commented 2 years ago

I'm not able to install this extension on a fresh Gitpod environment.

Getting

nstalling package 'OmniSharp for Linux (x64)'

Downloading package '.NET Core Debugger (linux / x64)' Failed to download from https://github.com/Samsung/netcoredbg/releases/download/1.2.0-825/netcoredbg-linux-amd64.tar.gz. Error code '404')
    Retrying from 'https://web.archive.org/web/20210704184708/https://github-releases.githubusercontent.com/113926796/fc5bfc00-dc3b-11eb-8d47-f99c4dc1c4c6?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20210704%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20210704T184708Z&X-Amz-Expires=300&X-Amz-Signature=521e3d193946f1cd4598e55056b7597497e294322daa6827f3bf84d1be4e1d89&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=113926796&response-content-disposition=attachment%3B%20filename%3Dnetcoredbg-linux-amd64.tar.gz&response-content-type=application%2Foctet-stream' (NaN KB) Done!
Installing package '.NET Core Debugger (linux / x64)'

Failed at stage: installPackage

What's the workaround here then? I can't wait until a new version is released...

hm2075 commented 2 years ago

Download the patch version and install it manually

Or download the source and compile it yourself

muhammadsammy commented 2 years ago

v1.23.16 was released to OpenVSX with working debugger links :+1: