search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
113 stars 11 forks source link

Is the runtime license change legal? #3

Closed spoenemann closed 3 years ago

spoenemann commented 3 years ago

In https://github.com/muhammadsammy/free-omnisharp-vscode/commit/6890051d34fad7a413eedbcef3470aa586d5f115 you changed the runtime license from Microsoft's proprietary license to MIT / Apache-2.0. @muhammadsammy are you sure you are allowed to do this?

The License section in the original README states

The Microsoft C# extension is subject to these license terms.

muhammadsammy commented 3 years ago

I've removed the "Debugger" runtimeDependency which have a proprietary license here: 3d32a99. This extension have "Razor" (Apache-2.0) and "Omnisharp" (MIT) runtime dependencies only and the source code for the original repo is MIT, so as far as I know, it's ok to remove the proprietary license.

spoenemann commented 3 years ago

For vscode there is a Wiki page explaining the difference between the MIT licensed source and the proprietary distribution. It would be nice to have a similarly clear statement about omnisharp-vscode by its maintainers.

But if you are sufficiently confident about the license change, feel free to close this issue.

spoenemann commented 3 years ago

@muhammadsammy the license change was effective since version 1.23.2, right? I'd like to delete the previous versions with the proprietary license from open-vsx.org, since they cannot be used from VSCodium and other non-Microsoft clients.

muhammadsammy commented 3 years ago

@spoenemann Sure! versions prior to 1.23.2 does have the proprietary license.

spoenemann commented 3 years ago

Ok, I deleted the older versions.