search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
110 stars 10 forks source link

Add support for platform specific extensions #39

Closed pm4rcin closed 1 year ago

pm4rcin commented 2 years ago

Hi, I've opened this issue to discuss the integration of platform-specific extensions. There are names of architectures in the link. From what I see it should be easy to add. I think most of the code could be copied from release ci. Open-vsx needs --target option with the platform name e.g. win32-x64. So we could just copy run commands with different platform names and eventually later refactor it.

PS. One thing that I'd like @muhammadsammy to do is to pull the changes (since the workflows have changed a bit on upstream) that are part of 1.25.0 release so I could edit workflows in my fork but to not create a release so we could try to implement this feature and since it's still marked as pre-release on upstream. PS2. I hope you understand what I've written. If not please ask. PS3. Here's an example for refactor but let's focus first on making it workng.

pm4rcin commented 2 years ago

Looks like there are some problems with that. If someone could look at that and tell me if I can specify something like `ovsx publish --target target1 target2 target3...``` or does it have to be in separate commands. In other words does --target support multiple targets in one command?

pm4rcin commented 1 year ago

Looks like we still have to wait for open-vsx to update it's publishing API https://github.com/EclipseFdn/open-vsx.org/issues/1084#issuecomment-1195276821

pm4rcin commented 1 year ago

The issue mentioned in my latest comment was fixed. I will try in the coming days. It should be just 2 lines change if I'm not mistaken. Here's how Terraform achieved that: https://github.com/hashicorp/vscode-terraform/blob/77ed4697a14cb519c17f94b4151b2c656d2e21b3/.github/workflows/publish.yml#L87-L97