search

muhammadsammy / free-vscode-csharp

Free/Libre fork of the official C# extension for vscode
https://open-vsx.org/extension/muhammad-sammy/csharp
Other
113 stars 11 forks source link

Fix NetCoreDbg download links #6

Closed TyMick closed 3 years ago

TyMick commented 3 years ago

Just installed this extension in VSCodium on Mac, and it was telling me it couldn't download the .NET Core Debugger. I think this should do the trick!

Turns out the Mac version in package.json was pointing to the download for the Windows release, and actually the Windows download URL is outdated, too: the Windows release is now named netcoredbg-win64.zip instead of netcoredbg-win64-master.zip.

I also updated the archive URLs for both versions while I was at it.

I unfortunately wasn't able to test this PR myself, because npm install, vsce package, and npm run test all fail for me. I wonder if it has to do with the fact that I haven't downloaded the .NET Core Debugger, but I'm not sure.

$ npm install
⸨  ░░░░░░░░░░░░░░░░⸩ ⠧ loadDep:yauzl: sill install loadAllDepsIntoIde
> fsevents@1.2.13 install /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode/node_modules/glob-watcher/node_modules/fsevents
> node install.js

  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node

> fsevents@1.2.13 install /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode/node_modules/watchpack-chokidar2/node_modules/fsevents
> node install.js

  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node

> core-js@2.6.11 postinstall /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> csharp@1.23.5 postinstall /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode
> node ./node_modules/vscode/bin/install

$ vsce package
Executing prepublish script 'npm run vscode:prepublish'...

> csharp@1.23.5 vscode:prepublish /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode
> tsc -p ./ && webpack --mode production

 ERROR  npm failed with exit code 1
$ npm run test

> csharp@1.23.5 test /Users/tymick/dev/muhammadsammy/free-omnisharp-vscode
> gulp test

$