search

muhdbhz / pe

0 stars 0 forks source link

Wrong command exception thrown for invalid command format (tag thrown instead) #7

Open muhdbhz opened 4 days ago

muhdbhz commented 4 days ago

Example

image.png

Description

I use the addstudent command format for addparent and expected an incorrect command format exception to be thrown. This time round I received a "tag should be alphanumeric" error thrown when the tag is indeed valid.

Steps to Reproduce

  1. Run clear
  2. Run addparent n/john doe p/123123 e/johnd@example a/311 t/dumb lt/tue:12:00 edu/primary

Severity Reason

Could be misleading

soc-pe-bot commented 1 day ago

Team's Response

This is similar to two other bug reports we have received titled Wrong exception thrown for invalid command format (email error thrown instead) and Wrong exception thrown for invalid command format (n/ thrown instead). We have come to a similar conclusion for this issue as it seems that lt/tue:12:00 edu/primary was inputted as part of a tag argument. Just like the other issues, we believe the suggested change is more incorrect than the current behaviour as it is possible for a user to input such an incorrect tag. Similar to the other issues, in the case this might be a valid bug, we consider it a severity.Low as it only causes minor inconveniences and would rarely occur.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong exception thrown for invalid command format (email error thrown instead)

Example

image.png

Description

The email jenny123@gmail.com is valid but I wrote extra fields deliberately. I expected an invalid command format error but I got the "email is invalid" error instead.

Steps to reproduce

  1. Run this command addparent n/jenny p/456 a/311 e/jenny123@gmail.com edu/primary lt/tue:12:00

Severity Reason

Could be misleading

[original: nus-cs2103-AY2425S1/pe-interim#1807] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your bug report. This is similar to two other bug reports we received titled Wrong exception thrown for invalid command format (n/ thrown instead) and Wrong command exception thrown for invalid command format (tag thrown instead). Our team has reviewed the error given and it seemed appropriate as in the command given you provided jenny123@gmail.com edu/primary lt/tue:12:00 as an argument for the email field. We believe from the user's point of view the suggested fix of having this be a command format error would be even more incorrect as it is possible for them to mistype emails in a way that looks like a command prefix. Due to these factors, we have concluded that the program is working as expected and thus have to reject this report. Furthermore, even if this were to be considered a bug according to the rationale given in the original bug report, we would only consider it a severity.Low as it only causes minor inconveniences to the user and would be rarely encountered as a user who has read our user guide would know not to put these prefixes in.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]