Open oliviertassinari opened 1 year ago
Off-topic, I really feel the lack of animation on the tooltip, it feels rusty without it. I think it's much most important to fix than this issue that I opened here π.
@oliviertassinari animation/transition is tracked here https://github.com/mui/material-ui/issues/36695.
@oliviertassinari I would like to pick this up
Radix UI solves this with a custom collisionPadding
prop on the Popper.
I think we depends on a fix in Base UI: https://github.com/mui/base-ui/issues/39.
Steps to reproduce πΉ
Link to live example:
Steps:
Current behavior π―
Expected behavior π€
Context
Material UI handles this a bit better:
https://github.com/mui/material-ui/blob/e64928daf64fcce9702e2659e44ecb348aa97403/packages/mui-material/src/Tooltip/Tooltip.js#L130
though we might want 4px, it feels much better than 2px. But note that the implementation of it in Material UI is broken, the 2px is also included for the start positioning placement π. We need to fix this too.
The Popover component has a
marginThreshold
prop for this very use case.Benchmark
Radix Primitive solves this with a custom
collisionPadding
prop on the Popper.Off-topic
I really feel the lack of animation on the tooltip in Joy UI, I wouldn't use this component as is in a side-project. I think it's x10 more important to fix the transition than this issue that I opened here π.
Your environment π
@mui/joy
v5.0.0-alpha.84cc @siriwatknp
Search keywords: