mui / base-ui

Base UI is a library of headless ("unstyled") React components and low-level hooks. You gain complete control over your app's CSS and accessibility features.
https://mui.com/base-ui/
MIT License
178 stars 34 forks source link

[Tooltip] Tooltip touch the edge #413

Open oliviertassinari opened 1 year ago

oliviertassinari commented 1 year ago

Steps to reproduce πŸ•Ή

Link to live example:

Steps:

  1. https://codesandbox.io/s/cranky-napier-rghkwn
  2. This feels off. I first saw this in https://github.com/mui/material-ui/issues/23232#issuecomment-715991707

Current behavior 😯

Screenshot 2023-06-17 at 19 40 02

Expected behavior πŸ€”

Screenshot 2023-06-17 at 19 38 19

Context

Benchmark

Off-topic

I really feel the lack of animation on the tooltip in Joy UI, I wouldn't use this component as is in a side-project. I think it's x10 more important to fix the transition than this issue that I opened here 😁.

Your environment 🌎

@mui/joy v5.0.0-alpha.84

cc @siriwatknp

Search keywords:

siriwatknp commented 1 year ago

Off-topic, I really feel the lack of animation on the tooltip, it feels rusty without it. I think it's much most important to fix than this issue that I opened here 😁.

@oliviertassinari animation/transition is tracked here https://github.com/mui/material-ui/issues/36695.

gitstart commented 1 year ago

@oliviertassinari I would like to pick this up

oliviertassinari commented 11 months ago

Radix UI solves this with a custom collisionPadding prop on the Popper.

oliviertassinari commented 10 months ago

I think we depends on a fix in Base UI: https://github.com/mui/base-ui/issues/39.