[Dialog, AlertDialog] Fix trigger issues

mui / base-ui

Base UI is an open-source library of accessible, unstyled UI components for React.

MIT License

288 stars 47 forks source link

Closed michaldudak closed 2 weeks ago

michaldudak commented 2 weeks ago

Refactored the implementation of the Dialog to be more in line with other popup-like components by delegating the trigger logic to Floating UI.

This fixes two issues: fixes #618 fixes #619

mui-bot commented 2 weeks ago

Generated by :no_entry_sign: dangerJS against 0016fcb1f63510e0202c6c6971dd7eb34aed3d27

atomiks commented 2 weeks ago

In Safari:

Under the Nested section demo, focus the Open trigger with Tab/keyboard and click with Enter
Press Escape
Scroll back to the top introduction demo
With your pointer, click the trigger
Press Escape
Focus moves back to the Nested open trigger incorrectly, not the intro trigger

michaldudak commented 2 weeks ago

Safari should work fine now.