[core] Make callback parameters consistent

mui / base-ui

Base UI is an open-source library of accessible, unstyled UI components for React.

MIT License

291 stars 47 forks source link

Closed michaldudak closed 1 week ago

michaldudak commented 1 week ago

Renamed the first parameter to match the callback name (value in onValueChange, checked in onCheckedChange, etc.).
Using native events in all public event handlers.
Renamed SliderRoot.onValueChange second parameter to activeThumbIndex and moved it to the third position.

mui-bot commented 1 week ago

Generated by :no_entry_sign: dangerJS against 67ee27ade2f9005a7336ac4cd9686d4ddd2b64ae

michaldudak commented 1 week ago

No, it's from the lastest master. Is the docs:api script supposed to update these files?

vladmoroz commented 1 week ago

No, it's from the lastest master. Is the docs:api script supposed to update these files?

Duh I realised it's not updated because there is an override on Slider's onValueChange type

Check docs/reference/overrides/slider-root.json

michaldudak commented 1 week ago

:/ that's an unfortunate consequence of having the definitions in several places. I hope we'll have time to do this properly soon.

vladmoroz commented 1 week ago

Yeah totally agree @michaldudak Will start getting a lot easier though when we don't have two sets of API data for the docs