[docs] Place Quick Nav after the main demo in the DOM

mui / base-ui

Base UI is an open-source library of accessible, unstyled UI components for React.

MIT License

291 stars 47 forks source link

[docs] Place Quick Nav after the main demo in the DOM #845

Open vladmoroz opened 1 week ago

vladmoroz commented 1 week ago

Place Quick Nav after the main demo in the DOM so that keyboard focus follows the reading order

https://deploy-preview-845--base-ui.netlify.app/new/components/dialog

mui-bot commented 1 week ago

Netlify deploy preview

https://deploy-preview-845--base-ui.netlify.app/

Generated by :no_entry_sign: dangerJS against cc6ae2bc534e25342a8ec1a222f4fc557fb7b879

colmtuite commented 1 week ago

@vladmoroz Imo, this won't be expected behaviour when headings become links.

vladmoroz commented 1 week ago

@vladmoroz Imo, this won't be expected behaviour when headings become links.

Hmm what's the expected behaviour in that case?
I wouldn't do heading links personally, I think quick nav is perfectly sufficient for grabbing a link to a section. I like plain, non-clickable headings. Would this be too much of a contentious choice?

colmtuite commented 6 days ago

Discussed on a call:

Imo, headings should be links in some fashion. I appreciate that it's annoying when the actual heading is clickable, it's nice to be able to select or click headings for no reason at all while you're reading. But we could put a link icon beside each heading, or something similar.

Imo, when focus is in the main content pane, it should remain there. Sidebar will/should be considered a separate pane. So focus should either go to sidebar first or last.