[ScrollArea] Fix margin/padding scrollbar calculations

mui / base-ui

Base UI is an open-source library of accessible, unstyled UI components for React.

MIT License

288 stars 47 forks source link

[ScrollArea] Fix margin/padding scrollbar calculations #861

Open atomiks opened 9 hours ago

atomiks commented 9 hours ago

[x] I have followed (at least) the PR section of the contributing guide.

The user can specify padding or margin in their CSS to offset the scrollbar, but these weren't being handled correctly by the calculations; specifically:

padding on the Scrollbar part
margin on the Thumb part

mui-bot commented 9 hours ago

Netlify deploy preview

https://deploy-preview-861--base-ui.netlify.app/

Generated by :no_entry_sign: dangerJS against bd34581b8c8b4bf1d55babe5d74caf30b6bc800b

vladmoroz commented 5 hours ago

Would margin work on the Scrollbar part?

atomiks commented 5 hours ago

Would margin work on the Scrollbar part?

I tested it and it works as-is since it changes the height/width of the whole scrollbar part, so the calculation works correctly by default