JSS is causing Flow errors

mui / material-ui

Material UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.

https://mui.com/material-ui/

MIT License

92.4k stars 31.82k forks source link

JSS is causing Flow errors #10738

Closed eluchsinger closed 6 years ago

eluchsinger commented 6 years ago

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

No errors when using flow.

Current Behavior

I get a couple errors from the JSS library. grafik

Context

This was a topic in JSS a couple days ago. Apparently it's fixed. https://github.com/cssinjs/jss/issues/411

If I install the dependencies with yarn, it will install jss version 9.8.0.

grafik

Your Environment

Tech	Version
Material-UI	1.0.0-beta.38
React	16.2.0
browser	not important
JSS	9.8.0

oliviertassinari commented 6 years ago

@eluchsinger How is this issue related to Material-UI?

eluchsinger commented 6 years ago

Apparently that bug was fixed in jss@9.8.1. Do you have to update the MUI npm package to update the dependency? Because it should be OK when I look into package.json. https://github.com/mui-org/material-ui/blob/fd5d20332c5eac45ec2713113ae7f562ae1af95a/package.json#L79

oliviertassinari commented 6 years ago

@eluchsinger We keep the jss scope as wide as possible to avoid the duplication of the module in people bundle. 9.8.1 match our scope (^9.3.3). You need to update the version on your side. Either on your yarn.lock or package-lock.json.

eluchsinger commented 6 years ago

Just for the record: I could update the resolved dependencies of material-ui (my local installation) by using the following command: yarn upgrade material-ui