mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.76k stars 32.24k forks source link

[i10n] Improve Russian localization #18421

Closed gmltA closed 4 years ago

gmltA commented 4 years ago

There are some inconsistencies in Russian localization that was introduced recently.

https://github.com/mui-org/material-ui/commit/b7cb1c5f906f4656ea0f1363130f513f2923c60b#diff-4f0ea089313629267bec25abe661453fR130

Current Behavior 😯

Some strings have incorrect translation. Namely:

labelDisplayedRows: ({ from, to, count }) => `${from}-${to === -1 ? count : to} of ${count}`,
clearText: 'чистый',
closeText: 'близко',
loadingText: 'загрузка…',
openText: 'открыто',

Expected Behavior 🤔

Grammatically and semantically correct localization.

labelDisplayedRows: ({ from, to, count }) => `${from}-${to === -1 ? count : to} из ${count}`,
clearText: 'Очистить',
closeText: 'Закрыть',
loadingText: 'Загрузка…',
openText: 'Открыть',
oliviertassinari commented 4 years ago

@gmltA Thank you for the feedback and for catching it before the actual release. Do you want to submit a pull request? :)

gmltA commented 4 years ago

@oliviertassinari would love to.