Closed bbigras closed 4 years ago
@bbigras Please open the issue in JSS, It's an issue on their end. Also, I would be in favor of dropping the dependency on tiny-warning.
Requires the release of https://github.com/cssinjs/jss/pull/1315
I am getting a similar issue on v4.9.12 when react
and react-dom
are added as a peer dependency in my app (moving them to a normal dependency made the issue disappear):
./.yarn/$$virtual/@material-ui-core-virtual-613969f2c4/0/cache/@material-ui-core-npm-4.9.12-eaaa062c1e-2.zip/node_modules/@material-ui/core/Modal/TrapFocus.js
Module not found: @material-ui/core tried to access react (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.
I am getting a similar issue on v4.9.12 when react and react-dom are added as a peer dependency in my app (moving them to a normal dependency made the issue disappear):
peer dependencies of a library need to be added as normal dependencies in your app. This is unrelated to this issue.
If you want to be notified when this issue is fixed watch https://github.com/cssinjs/jss for releases (click "watch" and then "releases only"). More specifically, watch for the next release of jss-plugin-rule-value-function
.
JSS v10.2.0 was released, problem solved.
Current Behavior šÆ
When I run
yarn start
I get:Expected Behavior š¤
Steps to Reproduce š¹
Steps:
<Button>Test</Button>
to App.tsx (withimport Button from '@material-ui/core/Button';
)Context š¦
I'm trying to use yarn2 to get that sweet zero-Installs feature.
Your Environment š
OS: NixOS unstable
tsconfig.json