search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.53k stars 32.19k forks source link

A ton of warning in browser console #2136

Closed genyded closed 8 years ago

genyded commented 8 years ago

I'm using 13.2 and there are so many warnings in the console (and there are not actually logged as browser warnings so they can't be filtered out) that it's impossible to read any other real console output:

Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose Warning: onShow will be removed in favor of explicitly setting open Warning: onDismiss will be removed in favor of explicitly setting open and can be replaced by onRequestClose ...

oliviertassinari commented 8 years ago

This is the line responsible https://github.com/callemall/material-ui/blob/master/src/dialog.jsx#L296. I think that we should only display the warning if the property is a function and not using hasOwnProperty since DatePicker is transfering the property to the DatePickerDialog.

justjacksonn commented 8 years ago

I get this same problem. I think it may be other components as well? I see two to three pages of warnings/etc and I end up having to scroll up a while to see the initial output that I may spit out.

oliviertassinari commented 8 years ago

Should be fixed now. I'm gonna let the issue open until the next release

oliviertassinari commented 8 years ago

We have just released.

Ben07 commented 8 years ago

@oliviertassinari Hi,I'm using 0.13.3,I get this problem when I use TextField component.this warning appear when I edit content.

ps.I use react-quill(version 0.3.0).this page show these warnings