mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.92k stars 32.27k forks source link

[DatePicker] Missing exports in lab/index.js #23608

Closed havgry closed 3 years ago

havgry commented 3 years ago

The following components are not being exported in packages/material-ui-lab/src/index.js which seems like a trivial mistake to me. Any thoughts?

ClockPicker (fixed in next)
DateRangDelimiter
DateRangePickerDay
MonthPicker
PickersCalendarSkeleton
Tech Version
Material-UI v5.0.0-alpha.16
oliviertassinari commented 3 years ago

@havgry Well spotted, any component that has its own folder, so:

are missing. Do you want to submit a pull request to export them? :) We would only need them to be sorted ASC, e.g.:

diff --git a/packages/material-ui-lab/src/index.d.ts b/packages/material-ui-lab/src/index.d.ts
index 1d3613aa22..56205bae2e 100644
--- a/packages/material-ui-lab/src/index.d.ts
+++ b/packages/material-ui-lab/src/index.d.ts
@@ -100,6 +100,9 @@ export * from './MobileDatePicker';
 export { default as StaticDatePicker } from './StaticDatePicker';
 export * from './StaticDatePicker';

+export { default as DateRangePickerDay } from './DateRangePickerDay';
+export * from './DateRangePickerDay';
+
 export { default as TimePicker } from './TimePicker';
 export * from './TimePicker';

diff --git a/packages/material-ui-lab/src/index.js b/packages/material-ui-lab/src/index.js
index 90c6b78f59..986d79c602 100644
--- a/packages/material-ui-lab/src/index.js
+++ b/packages/material-ui-lab/src/index.js
@@ -53,6 +53,9 @@ export * from './StaticDateTimePicker';
 export { default as DateRangePicker } from './DateRangePicker';
 export * from './DateRangePicker';

+export { default as DateRangePickerDay } from './DateRangePickerDay';
+export * from './DateRangePickerDay';
+
 export { default as DesktopDateRangePicker } from './DesktopDateRangePicker';
 export * from './DesktopDateRangePicker';

Regarding DateRangeDelimiter, I think that we should drop it. It can be replaced with <Box sx={{ mx: 2 }} />: #23609.

havgry commented 3 years ago

Small fix, I'll do the PR (without DateRangeDelimiter).