mui / material-ui

Materialย UI: Ready-to-use foundational React components, free forever. It includes Material UI, which implements Google's Material Design.
https://mui.com/material-ui/
MIT License
92.42k stars 31.83k forks source link

Not able to install icons yarn add @material-ui/icons package #26240

Open Santosh-13 opened 3 years ago

Santosh-13 commented 3 years ago

Current Behavior ๐Ÿ˜ฏ

info There appears to be trouble with your network connection. Retrying...

Expected Behavior ๐Ÿค”

Steps to Reproduce ๐Ÿ•น

Steps:

1.yarn add @material-ui/icons, showing network errors image

Context ๐Ÿ”ฆ

Your Environment ๐ŸŒŽ

`npx @material-ui/envinfo` ``` Don't forget to mention which browser you used. Output from `npx @material-ui/envinfo` goes here. ```
oliviertassinari commented 3 years ago

@Santosh-13 which version are you trying to install?

Duplicate of #12432?

Santosh-13 commented 3 years ago

@oliviertassinari , https://github.com/mui-org/material-ui/issues/12432#issuecomment-411046157 has the fix in the discussion and it worked. I think this issue can be closed.

Santosh-13 commented 3 years ago

Thank you:)

oliviertassinari commented 3 years ago

which version are you trying to install?

Looking at your screenshot, I conclude v4, which we haven't changed for a year.

oliviertassinari commented 3 years ago

@eps1lon would you rather keep this issue open so we can talk about future improvements or close as a duplicate?

With developers keep struggling on v4, and v5 adding a good +30% more icons, it seems that we need to do something about it.

eps1lon commented 3 years ago

With developers keep struggling on v4, and v5 adding a good +30% more icons, it seems that we need to do something about it.

Agreed. I do have some ideas that should hopefully get us down to the v4 install size. Even going so far as just shipping ES modules since we no longer support node 10 but that's a bit more prone to bugs.

But that requires an update to the icons itself which aren't checked in. So first we need to update the icons (probably ignore the new ones) and then vendor in material-ui-icons/material-icons.

oliviertassinari commented 3 years ago

26310 was reverted in #26656 as it breaks Next.js.