Open datoslabs opened 3 years ago
Process Completed I have solved the problem but does not pass the CI...
tancarlson:scc-branch
Those are the problem encountered
Thanks for the feedback.
Frozen repro with v5: https://codesandbox.io/s/basicaccordion-material-demo-forked-l3u0y?file=/demo.tsx
We could fix this by adding style={{overflow:'hidden'}}
to the parent Accordion
or applying the same border-radius to the AccordionDetails
and AccordionSummary
.
Would be nice if somebody could explore both of these approaches and file a PR with what they think works best so that we can investigate.
Hi @eps1lon I will take up the issue and create a PR.
Hi @eps1lon I have created a Pull Request can you please go through it.
These are the checks I am not able to pass can you help me
while working with Accordion I came across this issue, How I solved it in my project is I put below styles in Parent of Accordion,
"& .MuiPaper-root:first-of-type": { borderRadius: "12px !important", }, "& .MuiPaper-root:last-of-type": { borderRadius: "12px !important", }
When
AccordionSummary
is given an opaque background color, the first child's top-left/right and last child's bottom-left/right corners appear to be squared even though theMuiAccordion-rounded:first-child
andMuiAccordion-rounded:last-child
styles are correctly applied. This occurs because theAccordionSummary
's corners are squared, stacking on top of the parent div (ieAccordion
); whenAccordionSummary
's background color is transparent, this does not cause an issue but when its background color is opaque, the first and lastAccordions
' corners will appear as squared.Current Behavior π―
When
AccordionSummary
is given an opaque background color, the first child's top-left/right and last child's bottom-left/right corners appear to be squared instead of rounded.Expected Behavior π€
Frist and last Accordion's corners should be rounded.
Steps to Reproduce πΉ
Steps:
style={{backgroundColor:'blue'}}
to each of theAccordionSummary
elementsContext π¦
Accordion
display should be consistent and its first and last child's corner rounding should not be affected by theAccordionSmmary
's color.Your Environment π
Material-ui Accordion demo example.