search

mui / material-ui

Material UI: Comprehensive React component library that implements Google's Material Design. Free forever.
https://mui.com/material-ui/
MIT License
93.97k stars 32.28k forks source link

[internal] Checklist of new opportunities with React 18 release #29844

Open eps1lon opened 2 years ago

eps1lon commented 2 years ago

Tracking issue for work we should do once React 18 is released as stable

mbrevda commented 2 years ago

React 18 was released!

Ayushsanjdev commented 2 years ago

I was also struggling with same issue, instead of npm, working with yarn

eps1lon commented 2 years ago

Please open an issue and follow the template if you're having problems.

ncesar commented 2 years ago

are we going to get mui4 support on 18 as well?

oliviertassinari commented 2 years ago

are we going to get mui4 support on 18 as well?

@ncesar React 18 support for Material UI v4 is not planned and is very unlikely. Instead, if needed, we will invest time in making the migration from v4 to v5 smoother for developers.

VanTanev commented 2 years ago

Hey, I understand that as an OSS developer this might be a very annoying question, but do you have some general guidance or timeline on when we might see React 18 support complete?

Thanks!

eps1lon commented 2 years ago

timeline on when we might see React 18 support complete?

You mean regarding streaming support? That's currently the only thing that might be missing as far as I know. Though I would suggest opening a new issue with a minimal reproduction that illustrates current issues with streaming rendering.

VanTanev commented 2 years ago

@eps1lon Hey, thanks for answering!

I'm currently evaluating moving to React 18 and from reading this issue my understanding was that MUI 5 is not ready. I hadn't actually tested implementing it yet.

If MUI is considered ready for React 18, that's great!

eps1lon commented 2 years ago

v5 is compatible as far as we know. The only thing you need to figure out is using streaming rendering. That's unclear to me at the moment.

klaskowski commented 2 years ago

Could we update peerDependency in @mui/styles to React 18? Or is there still something that holds us back?

mnajdova commented 2 years ago

Could we update peerDependency in @mui/styles to React 18? Or is there still something that holds us back?

@mui/styles is not compatible with concurrent mode and react 18, this is why it isn't added in the peer dependencies. The other packages already have React 18 in their peer dependencies.

It is stated in its documentation - https://mui.com/system/styles/basics/

jcoc611-gvt commented 1 year ago

Seems like @mui/utils has a dependency "@types/react-is": "^16.7.1 || ^17.0.0",. Should this be updated to include || ^18.0.0 so it ends up using the correct @types/react@18.2.0?

oliviertassinari commented 1 year ago

@jcoc611-gvt right, on the latest release v5.12.2:

https://github.com/mui/material-ui/blob/22b7f0c0a0d3a87113a34a85c27ccb8053e02487/packages/mui-utils/package.json#L47

It doesn't have 18 in its scope, it's a bit strange considering: https://www.npmjs.com/package/@types/react-is?activeTab=versions.

eps1lon commented 1 year ago

@types/react-is 18.x was kinda forgotten. It was just recently released 5 days ago without any changes.

dio commented 10 months ago

Sorry, can we update "MUI Styles React 17 peer dependency (Support for React 18)" issue https://github.com/mui/material-ui/issues/35362? Thank you!